skip unimplemented error; update workflow#10
Open
Yejing-Lai wants to merge 1 commit intodelock:gma/cpu_supportfrom
Open
skip unimplemented error; update workflow#10Yejing-Lai wants to merge 1 commit intodelock:gma/cpu_supportfrom
Yejing-Lai wants to merge 1 commit intodelock:gma/cpu_supportfrom
Conversation
Owner
|
Overall comments: we should avoid compare backend name against certain accelerator name. Instead, check for certain features that are required by the case. These tests that check for not implemented is a good example. Its reasonable to skip a UT if feature are not implemented, but not reasonable to skip just because it cannot pass for certain accelerator. |
c86bb2b to
e759de6
Compare
e759de6 to
4d01301
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skip logic: