Adding PhysicalCraftingRecipe class#15
Open
rmichela wants to merge 1 commit intodesht:masterfrom
rmichela:PhysicalCraftingRecipe
Open
Adding PhysicalCraftingRecipe class#15rmichela wants to merge 1 commit intodesht:masterfrom rmichela:PhysicalCraftingRecipe
rmichela wants to merge 1 commit intodesht:masterfrom
rmichela:PhysicalCraftingRecipe
Conversation
Owner
|
Looks interesting, but what sort of applications do you have for it? |
Contributor
Author
|
I use it to grow giant trees by surrounding an emerald block by two rings of saplings. This class detects the pattern on the ground. |
Contributor
Author
|
Anything I need to do to make PhysicalCraftingRecipe merge worthy? |
Owner
|
Not at the moment, no - I just haven't had a proper chance to look it through yet... RL commitments plus other plugin dev stuff going on. Hopefully will get a chance early next week... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a PhysicalCraftingRecipe class for triggering actions when the user lays out blocks on the ground. It supports rectangular patterns, works in any horizontal orientation, and can identify item data values. The API is very similar to the Bukkit crafting recipe class. I've been using it in GiantTrees for a while now and it's pretty quick. I thought this would be a good addition to deshtutils.