Draft
Conversation
Test Results206 tests 206 ✅ 8m 37s ⏱️ Results for commit ec8bf85. ♻️ This comment has been updated with latest results. |
Benchmark Results |
deven96
reviewed
Dec 22, 2025
ahnlich/similarity/src/hnsw.rs
Outdated
| #[derive(Debug, Clone)] | ||
| pub struct LayerIndex(pub u16); | ||
|
|
||
| impl PartialEq for LayerIndex { |
Owner
There was a problem hiding this comment.
I think you can derive PartialEq and Eq since it's a simple new type
deven96
reviewed
Dec 22, 2025
ahnlich/similarity/src/hnsw.rs
Outdated
| } | ||
|
|
||
| /// NodeId wraps String(hash of node embeddings) to uniquely identify a node across all layers. | ||
| #[derive(Debug, Clone)] |
abf6b5f to
1ef1e7e
Compare
1ef1e7e to
9d4b5d0
Compare
…edge case at search layer(should not error).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #184. Introduces the HNSW implementation with little to no improvements(Correctness over optimization)