Skip to content

Conversation

@andrewbattat
Copy link
Contributor

@andrewbattat andrewbattat commented Jan 2, 2026

NODE-1808

Adds GuestOSConfig, HostOSConfig, and SetupOSConfig Default trains to reduce test boilerplate. Unit tests now only must specify specific fields they care about.

@andrewbattat andrewbattat self-assigned this Jan 2, 2026
@github-actions github-actions bot added the chore label Jan 2, 2026
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request modifies the IC-OS configuration types library (rs/ic_os/config_types/src/lib.rs).

Please ensure you have followed the Configuration Update Protocol guidelines——particularly if adding a new enum or enum variants:

Enum Variant Forward Compatibility Guidelines: If adding a new enum or new variants to an enum, ensure older versions can handle unknown variants gracefully by using #[serde(other)] on a fallback variant. See examples: GuestVMType::Unknown and Ipv6Config::Unknown.

To acknowledge this reminder and unblock the PR, dismiss this code review by:

  • Going to the bottom of the pull request page
  • Finding where this bot is requesting changes
  • Clicking the three dots on the right
  • Selecting "Dismiss review"

For complete guidelines, see the documentation at the top of rs/ic_os/config_types/src/lib.rs.

CONFIG_TYPES_COMPATIBILITY_REMINDER_DEDUP

@andrewbattat andrewbattat dismissed github-actions[bot]’s stale review January 2, 2026 19:29

Only changes to test code

@andrewbattat andrewbattat changed the title chore(node): add OSConfig test_config utility test(node): add OSConfig test_config utility Jan 2, 2026
@github-actions github-actions bot added test and removed chore labels Jan 2, 2026
@andrewbattat andrewbattat marked this pull request as ready for review January 2, 2026 21:00
@andrewbattat andrewbattat requested a review from a team as a code owner January 2, 2026 21:00
@github-actions github-actions bot added the @node label Jan 2, 2026
@andrewbattat andrewbattat changed the title test(node): add OSConfig test_config utility test(node): add OSConfig Default traits Jan 7, 2026
@andrewbattat andrewbattat enabled auto-merge January 7, 2026 22:37
@andrewbattat andrewbattat added this pull request to the merge queue Jan 7, 2026
Merged via the queue into master with commit 035a2c7 Jan 7, 2026
39 checks passed
@andrewbattat andrewbattat deleted the andrew/icos-config-test-config branch January 7, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants