Conversation
Member
|
Just noticed this today when looking through opened pull requests in prep for deploying formplayer tonight. Assuming this change is still good/relevant, do you want to fix the merge conflict and get this into the release? |
Member
Author
|
Hey @dannyroberts This optimization doesn't add much on its own. I'm going to be adding a couple more pieces that make this more valuable but until then I don't think it's worth the weight / complexity |
snopoke
approved these changes
Dec 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests and integration of dimagi/commcare-core#905
Core value: allows the engine to optimize predicates with the pattern
[@indexed = 'x' OR @indexed = 'y']