fix(deps): exclude dds extra from uv sync --all-extras#1318
Merged
spomichter merged 1 commit intodevfrom Feb 20, 2026
Merged
Conversation
Greptile SummaryThis PR fixes a dependency installation issue by excluding the Changes:
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: e0655bc |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
spomichter
force-pushed
the
fix/exclude-dds-from-all-extras
branch
from
e0655bc to
f21365d
Compare
docs/installation/osx.md
Outdated
Comment on lines
34
to
35
| uv venv --python 3.12 | ||
| source .venv/bin/activate |
Contributor
There was a problem hiding this comment.
Please remove this again:
uv venv --python 3.12
source .venv/bin/activate
uv sync creates it's own venv.
cyclonedds requires a source build with CYCLONEDDS_HOME set, which fails on standard dev machines. Updated install docs to use `uv sync --all-extras --no-extra dds` and added a note to the dds extra in pyproject.toml.
spomichter
force-pushed
the
fix/exclude-dds-from-all-extras
branch
from
f21365d to
a88c23b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cycloneddsrequires building from source withCYCLONEDDS_HOMEset, which fails on standard dev machines when runninguv sync --all-extras.Changes
uv sync --all-extras --no-extra ddsddsextra in pyproject.tomlHow to Test
Should resolve without attempting to build cyclonedds.