Skip to content

Comments

docs: add -s flag addopts#1320

Merged
spomichter merged 1 commit intodevfrom
fix/pytest-stdin-capture
Feb 20, 2026
Merged

docs: add -s flag addopts#1320
spomichter merged 1 commit intodevfrom
fix/pytest-stdin-capture

Conversation

@spomichter
Copy link
Contributor

@spomichter spomichter commented Feb 20, 2026

Summary

LCM autoconf prompts for system configuration during test collection, which fails without -s since pytest captures stdin by default.

Added -s to addopts

@greptile-apps
Copy link

greptile-apps bot commented Feb 20, 2026

Greptile Summary

Added -s flag to all uv run pytest dimos commands in documentation to prevent test failures when LCM autoconf prompts for system configuration.

  • Root cause: LCM's autoconf() function prompts user for system configuration during test collection (via input() at system_configurator.py:116), which fails when pytest captures stdin by default
  • Solution: The -s flag disables pytest's stdin/stdout capture, allowing interactive prompts to work correctly
  • Scope: Updated 6 instances across 5 documentation files (README.md and installation/development docs)
  • Consistency: All uv run pytest dimos commands now consistently include the -s flag

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • Documentation-only change that adds a correct pytest flag to resolve a real issue with stdin capture. The change is consistent, well-justified, and has zero risk of breaking functionality.
  • No files require special attention

Important Files Changed

Filename Overview
README.md Added -s flag to uv run pytest dimos command to enable stdin support for LCM autoconf prompts
docs/development/README.md Added -s flag to three instances of uv run pytest dimos command for stdin support
docs/installation/nix.md Added -s flag to uv run pytest dimos command to enable stdin support
docs/installation/osx.md Added -s flag to uv run pytest dimos command to enable stdin support
docs/installation/ubuntu.md Added -s flag to uv run pytest dimos command to enable stdin support

Last reviewed commit: 42f2561

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

LCM autoconf prompts for system configuration during test collection,
which fails without -s since pytest captures stdin by default.
@spomichter spomichter force-pushed the fix/pytest-stdin-capture branch from 42f2561 to 9814bbe Compare February 20, 2026 22:18
@spomichter spomichter changed the title docs: add -s flag to pytest commands for stdin support docs: add -s flag addopts Feb 20, 2026
@spomichter spomichter merged commit e40cf20 into dev Feb 20, 2026
2 checks passed
@spomichter spomichter deleted the fix/pytest-stdin-capture branch February 20, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant