Skip to content

Allow empty HMAC key (#176) #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terrier989 merged 1 commit into from
Nov 21, 2025
Merged

Allow empty HMAC key (#176) #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions cryptography/lib/src/browser/hmac.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,6 @@ class BrowserHmac extends Hmac {

Future<web_crypto.CryptoKey> _jsCryptoKey(SecretKey secretKey) async {
final secretKeyBytes = await secretKey.extractBytes();
if (secretKeyBytes.isEmpty) {
throw ArgumentError.value(
secretKey,
'secretKey',
'SecretKey bytes must be non-empty',
);
}
return await web_crypto.importKeyWhenRaw(
web_crypto.jsUint8ListFrom(secretKeyBytes),
web_crypto.HmacImportParams(
Expand Down
7 changes: 0 additions & 7 deletions cryptography/lib/src/dart/hmac.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,13 +120,6 @@ class _DartHmacSink extends MacSink with DartMacSinkMixin {
'AAD is not supported by HMAC',
);
}
if (secretKey.bytes.isEmpty) {
throw ArgumentError.value(
secretKey,
'secretKey',
'Secret key must be non-empty',
);
}
_isClosed = false;
var hmacKey = secretKey.bytes;
var eraseKey = false;
Expand Down
Loading