Skip to content

vendor: github.com/docker/cli v29.2.0 #3617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
thaJeztah wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

vendor: github.com/docker/cli v29.2.0 #3617

thaJeztah wants to merge 10 commits into from
+1,992 −945

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jan 19, 2026 •
edited
Loading

vendor: github.com/klauspost/compress v1.18.3

no changes in vendored code

full diff: klauspost/compress@v1.18.2...v1.18.3

vendor: github.com/go-viper/mapstructure/v2 v2.5.0

full diff: go-viper/mapstructure@v2.4.0...v2.5.0

vendor: moby/api v1.53.0, moby/client v0.2.2

full diff:

vendor: github.com/docker/cli v29.2.0

full diff: docker/cli@v29.1.5...v29.2.0

@thaJeztah thaJeztah force-pushed the bump_modules branch 2 times, most recently from bc4d37c to 78293e6 Compare January 27, 2026 08:26
@thaJeztah
vendor: golang.org/x/sys v0.40.0
40d068e 
full diff: https://cs.opensource.google/go/x/sys/+/refs/tags/v0.39.0...refs/tags/v0.40.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
vendor: golang.org/x/term v0.39.0
214ebd8 
full diff: https://cs.opensource.google/go/x/term/+/refs/tags/v0.38.0...refs/tags/v0.39.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
vendor: golang.org/x/tools v0.40.0
95a1cb9 
full diff: https://cs.opensource.google/go/x/tools/+/refs/tags/v0.39.0...refs/tags/v0.40.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
vendor: golang.org/x/text v0.33.0
746c343 
full diff: https://cs.opensource.google/go/x/text/+/refs/tags/v0.32.0...refs/tags/v0.33.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
vendor: golang.org/x/crypto v0.47.0
5d44afb 
full diffs:

- https://cs.opensource.google/go/x/crypto/+/refs/tags/v0.46.0...refs/tags/v0.47.0
- https://cs.opensource.google/go/x/net/+/refs/tags/v0.48.0...refs/tags/v0.49.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
vendor: golang.org/x/mod v0.32.0
efe1aa5 
full diffs:

- https://cs.opensource.google/go/x/tools/+/refs/tags/v0.39.0...refs/tags/v0.41.0
- https://cs.opensource.google/go/x/mod/+/refs/tags/v0.31.0...refs/tags/v0.32.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 27, 2026

Interesting failure https://github.com/docker/buildx/actions/runs/21389923862/job/61574127472?pr=3617

=== Failed
=== FAIL: dap TestLaunch (unknown)
    client.go:96: [client] send: {"seq":1,"type":"request","command":"initialize","arguments":{"adapterID":"","linesStartAt1":false,"columnsStartAt1":false}}
    server.go:74: [server] recv: {"seq":1,"type":"request","command":"initialize","arguments":{"adapterID":"","linesStartAt1":false,"columnsStartAt1":false,"pathFormat":"path"}}
    server.go:200: [server] send: {"seq":1,"type":"response","request_seq":1,"success":true,"command":"initialize","body":{"supportsConfigurationDoneRequest":true}}
    client.go:44: [client] recv: {"seq":1,"type":"response","request_seq":1,"success":true,"command":"initialize","body":{"supportsConfigurationDoneRequest":true}}
    client.go:96: [client] send: {"seq":2,"type":"request","command":"launch","arguments":null}
    server.go:74: [server] recv: {"seq":2,"type":"request","command":"launch","arguments":null}
    server.go:200: [server] send: {"seq":2,"type":"event","event":"initialized"}
    client.go:44: [client] recv: {"seq":2,"type":"event","event":"initialized"}
    client.go:96: [client] send: {"seq":3,"type":"request","command":"configurationDone"}
    server.go:200: [server] send: {"seq":3,"type":"response","request_seq":2,"success":true,"command":"launch"}
    server.go:74: [server] recv: {"seq":3,"type":"request","command":"configurationDone"}
    server.go:200: [server] send: {"seq":4,"type":"response","request_seq":3,"success":true,"command":"configurationDone"}
    client.go:44: [client] recv: {"seq":3,"type":"response","request_seq":2,"success":true,"command":"launch"}
    client.go:44: [client] recv: {"seq":4,"type":"response","request_seq":3,"success":true,"command":"configurationDone"}
    server.go:200: [server] send: {"seq":5,"type":"event","event":"terminated","body":{}}
panic: sync: WaitGroup is reused before previous Wait has returned

goroutine 28 [running]:
sync.(*WaitGroup).Wait(0x140004cc048)
	/Users/runner/hostedtoolcache/go/1.25.6/arm64/src/sync/waitgroup.go:208 +0x14c
golang.org/x/sync/errgroup.(*Group).Wait(0x140004cc040)
	/Users/runner/work/buildx/buildx/vendor/golang.org/x/sync/errgroup/errgroup.go:56 +0x28
github.com/docker/buildx/dap.(*Server).Serve.func4()
	/Users/runner/work/buildx/buildx/dap/server.go:61 +0x90
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/Users/runner/work/buildx/buildx/vendor/golang.org/x/sync/errgroup/errgroup.go:93 +0x4c
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 24
	/Users/runner/work/buildx/buildx/vendor/golang.org/x/sync/errgroup/errgroup.go:78 +0x90

DONE 829 tests, 1 skipped, 1 failure in 49.835s
Error: Process completed with exit code 1.

@thaJeztah thaJeztah mentioned this pull request Jan 27, 2026
Open
@thaJeztah thaJeztah changed the title vendor: github.com/docker/cli v29.2.0-rc.2 vendor: github.com/docker/cli v29.2.0 Jan 27, 2026
@thaJeztah
vendor: github.com/klauspost/compress v1.18.3
a3c3ecc 
no changes in vendored code

- fixes / downstream CVE-2025-61728

full diff: klauspost/compress@v1.18.2...v1.18.3

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
vendor: github.com/go-viper/mapstructure/v2 v2.5.0
050990e 
full diff: go-viper/mapstructure@v2.4.0...v2.5.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
vendor: moby/api v1.53.0, moby/client v0.2.2
dd5cd96 
full diff:

- api: moby/moby@api/v1.52.0...api/v1.53.0
- client: moby/moby@client/v0.2.1...client/v0.2.2

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
vendor: github.com/docker/cli v29.2.0
d38e665 
full diff: docker/cli@v29.1.5...v29.2.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 27, 2026

Same test, different failure; https://github.com/docker/buildx/actions/runs/21392736648/job/61583385477?pr=3617

=== RUN   TestLaunch
    client.go:96: [client] send: {"seq":1,"type":"request","command":"initialize","arguments":{"adapterID":"","linesStartAt1":false,"columnsStartAt1":false}}
    server.go:74: [server] recv: {"seq":1,"type":"request","command":"initialize","arguments":{"adapterID":"","linesStartAt1":false,"columnsStartAt1":false,"pathFormat":"path"}}
    server.go:200: [server] send: {"seq":1,"type":"response","request_seq":1,"success":true,"command":"initialize","body":{"supportsConfigurationDoneRequest":true}}
    client.go:44: [client] recv: {"seq":1,"type":"response","request_seq":1,"success":true,"command":"initialize","body":{"supportsConfigurationDoneRequest":true}}
    client.go:96: [client] send: {"seq":2,"type":"request","command":"launch","arguments":null}
    server.go:74: [server] recv: {"seq":2,"type":"request","command":"launch","arguments":null}
    server.go:200: [server] send: {"seq":2,"type":"response","request_seq":2,"success":true,"command":"launch"}
    server.go:200: [server] send: {"seq":3,"type":"event","event":"initialized"}
    client.go:44: [client] recv: {"seq":2,"type":"response","request_seq":2,"success":true,"command":"launch"}
    adapter_test.go:61: 
        	Error Trace:	/vagrant/dap/adapter_test.go:61
        	            				/vagrant/vendor/golang.org/x/sync/errgroup/errgroup.go:93
        	            				/usr/local/go/src/runtime/asm_amd64.s:1693
        	Error:      	did not receive initialized event
        	Test:       	TestLaunch
    client.go:44: [client] recv: {"seq":3,"type":"event","event":"initialized"}
    client.go:96: [client] send: {"seq":3,"type":"request","command":"configurationDone"}
    server.go:74: [server] recv: {"seq":3,"type":"request","command":"configurationDone"}
    server.go:200: [server] send: {"seq":4,"type":"response","request_seq":3,"success":true,"command":"configurationDone"}
    client.go:44: [client] recv: {"seq":4,"type":"response","request_seq":3,"success":true,"command":"configurationDone"}
    server.go:74: [server] recv error: context deadline exceeded
    adapter_test.go:67: 
        	Error Trace:	/vagrant/dap/adapter_test.go:67
        	            				/vagrant/vendor/golang.org/x/sync/errgroup/errgroup.go:93
        	            				/usr/local/go/src/runtime/asm_amd64.s:1693
        	Error:      	did not receive configurationDone response
        	Test:       	TestLaunch
--- FAIL: TestLaunch (10.04s)

Also failing; https://github.com/docker/buildx/actions/runs/21392736648/job/61583385468?pr=3617

=== FAIL: dap TestSetBreakpoints (10.01s)
    client.go:96: [client] send: {"seq":1,"type":"request","command":"initialize","arguments":{"adapterID":"","linesStartAt1":false,"columnsStartAt1":false}}
    server.go:74: [server] recv: {"seq":1,"type":"request","command":"initialize","arguments":{"adapterID":"","linesStartAt1":false,"columnsStartAt1":false,"pathFormat":"path"}}
    server.go:200: [server] send: {"seq":1,"type":"response","request_seq":1,"success":true,"command":"initialize","body":{"supportsConfigurationDoneRequest":true}}
    client.go:44: [client] recv: {"seq":1,"type":"response","request_seq":1,"success":true,"command":"initialize","body":{"supportsConfigurationDoneRequest":true}}
    client.go:96: [client] send: {"seq":2,"type":"request","command":"launch","arguments":null}
    server.go:74: [server] recv: {"seq":2,"type":"request","command":"launch","arguments":null}
    server.go:200: [server] send: {"seq":2,"type":"response","request_seq":2,"success":true,"command":"launch"}
    client.go:44: [client] recv: {"seq":2,"type":"response","request_seq":2,"success":true,"command":"launch"}
    adapter_test.go:122: 
        	Error Trace:	/home/runner/work/buildx/buildx/dap/adapter_test.go:122
        	            				/home/runner/work/buildx/buildx/vendor/golang.org/x/sync/errgroup/errgroup.go:93
        	            				/opt/hostedtoolcache/go/1.25.6/x64/src/runtime/asm_amd64.s:1693
        	Error:      	did not receive initialized event
        	Test:       	TestSetBreakpoints
    server.go:200: [server] send: {"seq":3,"type":"event","event":"initialized"}
    client.go:44: [client] recv: {"seq":3,"type":"event","event":"initialized"}
    client.go:96: [client] send: {"seq":3,"type":"request","command":"setBreakpoints","arguments":{"source":{"name":"Dockerfile","path":"/home/runner/work/_temp/TestSetBreakpoints2501232425/001/Dockerfile"}}}
    server.go:74: [server] recv: {"seq":3,"type":"request","command":"setBreakpoints","arguments":{"source":{"name":"Dockerfile","path":"/home/runner/work/_temp/TestSetBreakpoints2501232425/001/Dockerfile"}}}
    server.go:200: [server] send: {"seq":4,"type":"response","request_seq":3,"success":true,"command":"setBreakpoints","body":{"breakpoints":[]}}
    client.go:44: [client] recv: {"seq":4,"type":"response","request_seq":3,"success":true,"command":"setBreakpoints","body":{"breakpoints":[]}}
    server.go:74: [server] recv error: context deadline exceeded
    adapter_test.go:131: 
        	Error Trace:	/home/runner/work/buildx/buildx/dap/adapter_test.go:131
        	            				/home/runner/work/buildx/buildx/vendor/golang.org/x/sync/errgroup/errgroup.go:93
        	            				/opt/hostedtoolcache/go/1.25.6/x64/src/runtime/asm_amd64.s:1693
        	Error:      	did not receive setBreakpoints response
        	Test:       	TestSetBreakpoints

DONE 831 tests, 1 skipped, 1 failure in 59.764s
Error: Process completed with exit code 1.

@crazy-max crazy-max mentioned this pull request Jan 27, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@thaJeztah thaJeztah

Labels

area/dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@thaJeztah