Skip to content

Conversation

@htoyoda18
Copy link
Contributor

What I did
Added unit tests for the getDefaultFilters() function in pkg/compose/containers.go.

This function builds Docker API filter combinations and has conditional logic for handling oneOff modes and service selection.

Related issue

N/A

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@htoyoda18 htoyoda18 marked this pull request as ready for review January 12, 2026 13:33
@htoyoda18 htoyoda18 requested a review from a team as a code owner January 12, 2026 13:33
@htoyoda18 htoyoda18 requested review from glours and ndeloof January 12, 2026 13:33
@ndeloof
Copy link
Contributor

ndeloof commented Jan 12, 2026

compose test suite is mostly based on end-to-end tests, so we capture actual result when using the Moby API.

@htoyoda18
Copy link
Contributor Author

compose test suite is mostly based on end-to-end tests, so we capture actual result when using the Moby API.

Thanks for the clarification! I now understand that the project prefers E2E tests over unit tests for internal helpers to ensure actual behavior via the Moby API.

I'll close this PR for now. I appreciate the guidance and look forward to contributing in a way that better aligns with the project's goals in the future!

@htoyoda18 htoyoda18 closed this Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants