Make cli_home volume name dynamic (based on cli image name/version) #1297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmakarov
reviewed
May 13, 2020
bin/fin
Outdated
| export COMPOSE_CONVERT_WINDOWS_PATHS=1 | ||
|
|
||
| # get cli image version | ||
| CLI_IMAGE_VER=$(docker-compose --verbose config --hash="cli" 2>&1 | grep 'docker inspect_image <-' | cut -d"'" -f2 | sed 's#/#-#g;s#:#-#g') |
Member
There was a problem hiding this comment.
This adds almost 2s to load_configuration(), which is used in many places in fin.
So this would slow everything down substantially. We need to figure out a different approach.
lmakarov
requested changes
May 13, 2020
Member
lmakarov
left a comment
lmakarov
left a comment
There was a problem hiding this comment.
Using docker-compose config to get the cli image version carries a major performance hit across the board in fin. We have to find a different approach.
lmakarov
force-pushed
the
feature/dynamic_cli_home
branch
from
e96ccc9 to
1c30737
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #787