Azure Split - Step 4 - Cleanup #3917

paulmedynski · 2026-01-27T19:47:06Z

Description

This PR includes any remaining cleanup:

Addresses some suggestions/comments from the previous 3 PRs.
Fixes any issues with the downstream pipelines (CI, MDS Main, Official, AKV).
Anything else I've noticed along the way.

PR series:

Azure Split - Step 1 - Prep Work #3902:
- Merge changes that aren't directly related to the Azure split work, but that setup the stage for that work.
Azure Split - Step 2 - New Files #3904:
- Merge new files and related changes that do not affect the existing MDS projects or artifacts.
Azure Split - Step 3 - Tie Everything Together #3908:
- Merge the changes to MDS and pipelines that tie everything together.
Azure Split - Step 4 - Cleanup #3917:
- Any remaining tasks or cleanup.

Testing

Normal PR/CI pipeline runs will validate most changes.
Manual runs of the ADO.Net pipelines (MDS Main, Official, AKV).
Manual inspection of pipeline logs and artifacts will confirm some of the fiddly parts.

Copilot

Pull request overview

Final cleanup pass for the Azure split work, focusing on small code tidy-ups and pipeline/template adjustments for Azure/AKV/signing/PR validation.

Changes:

Minor test/source cleanup (namespace alignment, formatting, retry-after millisecond conversion).
Pipeline/template refactors to consolidate .NET SDK installation and simplify signing/package validation steps.
Updates to PR validation and CodeQL trigger configuration.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/SqlAuthenticationProviderManagerTests.cs	Aligns unit test namespace/formatting with the rest of the UnitTests tree.
src/Microsoft.Data.SqlClient.Extensions/Azure/test/StringExtensions.cs	Adds XML docs for `Empty()` (currently attached to the wrong symbol).
src/Microsoft.Data.SqlClient.Extensions/Azure/src/ActiveDirectoryAuthenticationProvider.cs	Fixes retry-after delta conversion to use total milliseconds; whitespace cleanup.
src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationProviderException.cs	Formatting-only change for ternary expression.
eng/pipelines/steps/compound-build-akv-step.yml	Removes redundant SDK install step from the AKV compound step.
eng/pipelines/sqlclient-pr-project-ref-pipeline.yml	Adjusts PR branch include pattern for `dev/*`.
eng/pipelines/sqlclient-pr-package-ref-pipeline.yml	Adjusts PR branch include pattern for `dev/*`.
eng/pipelines/jobs/test-azure-package-ci-job.yml	YAML formatting cleanup (folded block style) for debug output step.
eng/pipelines/jobs/build-akv-official-job.yml	Adds explicit `.NET SDK` install before AKV build/analyzers.
eng/pipelines/dotnet-sqlclient-signing-pipeline.yml	Updates artifact folder naming and simplifies validation job invocation.
eng/pipelines/common/templates/steps/code-analyze-step.yml	Changes analyzer MSBuild invocation to explicitly target `BuildAllConfigurations`.
eng/pipelines/common/templates/steps/build-all-configurations-signed-dlls-step.yml	Removes redundant SDK install from this step template.
eng/pipelines/common/templates/jobs/validate-signed-package-job.yml	Simplifies parameters and inlines the artifact download step.
eng/pipelines/common/templates/jobs/build-signed-package-job.yml	Switches to `pwsh`, installs SDK, passes Abstractions version property, and sets build-type output variable (currently broken).
.github/workflows/codeql.yml	Updates CodeQL triggers/comments (push trigger now unscoped).

Copilot · 2026-01-27T19:53:14Z

src/Microsoft.Data.SqlClient.Extensions/Azure/test/StringExtensions.cs

+/// <param name="str">The string to check; must not be null</param>
 internal static class StringExtensions
 {


The XML doc <param name="str"> is attached to the StringExtensions class, but param tags are only valid on members that have parameters (methods/constructors/indexers/delegates). This will generate an XML-doc compiler warning (and can fail builds if warnings are treated as errors). Move the <param> doc to the Empty(this string str) method (and optionally add <summary>/<returns> there).

Suggested change

/// <param name="str">The string to check; must not be null</param>

internal static class StringExtensions

{

internal static class StringExtensions

{

/// <summary>

/// Determines whether the specified string is empty without performing a null check.

/// </summary>

/// <param name="str">The string to check; must not be null.</param>

/// <returns><see langword="true"/> if the string is empty; otherwise, <see langword="false"/>.</returns>

Copilot · 2026-01-27T19:53:14Z

eng/pipelines/common/templates/jobs/build-signed-package-job.yml


-  - powershell: |
+  - pwsh: |
      Write-Host "##vso[task.setvariable variable=CDP_BUILD_TYPE_COPY;isOutput=true]$($env:CDP_BUILD_TYPE)"


This step sets an output variable (isOutput=true), but it no longer has a name:. Downstream references use stageDependencies...outputs['GetBuildType.CDP_BUILD_TYPE_COPY'], which requires the step name to be GetBuildType. Add name: GetBuildType (keep displayName if desired) so the output can be consumed.

Suggested change

Write-Host "##vso[task.setvariable variable=CDP_BUILD_TYPE_COPY;isOutput=true]$($env:CDP_BUILD_TYPE)"

Write-Host "##vso[task.setvariable variable=CDP_BUILD_TYPE_COPY;isOutput=true]$($env:CDP_BUILD_TYPE)"

name: GetBuildType

Copilot · 2026-01-27T19:53:15Z

.github/workflows/codeql.yml

+  # Scan on pushes to the default branch and any protected branches.
  push:
-    branches: [ "main", "feat/*", "dev/**/*" ]
+


push: is now configured without a branches: filter, so CodeQL will run on pushes to all branches. That contradicts the comment (“default branch and any protected branches”) and can significantly increase CI load. Add an explicit push.branches filter (e.g., main, dev/**, feat/**) or update the comment/logic to match the intended scope.

Copilot · 2026-01-27T19:53:15Z

eng/pipelines/sqlclient-pr-project-ref-pipeline.yml

+    - dev/*
    - feat/*
    - main


This changes the PR trigger include pattern from dev/**/* to dev/*, which no longer matches nested dev branches like dev/foo/bar (Azure Pipelines glob semantics treat * as a single path segment). If nested dev/ branches are used, PR validation will stop running for them; consider using dev/** to preserve previous behavior.

Copilot · 2026-01-27T19:53:15Z

eng/pipelines/sqlclient-pr-package-ref-pipeline.yml

+    - dev/*
    - feat/*
    - main


This changes the PR trigger include pattern from dev/**/* to dev/*, which no longer matches nested dev branches like dev/foo/bar (Azure Pipelines glob semantics treat * as a single path segment). If nested dev/ branches are used, PR validation will stop running for them; consider using dev/** to preserve previous behavior.

Copilot · 2026-01-27T19:53:15Z

src/Microsoft.Data.SqlClient.Extensions/Azure/src/ActiveDirectoryAuthenticationProvider.cs

+                        if (retryAfter.Delta.Value.TotalMilliseconds > int.MaxValue)
+                        {
+                            retryPeriod = int.MaxValue;
+                        }
+                        else
+                        {
+                            retryPeriod = Convert.ToInt32(retryAfter.Delta.Value.TotalMilliseconds);
+                        }


Both branches of this 'if' statement write to the same variable - consider using '?' to express intent better.

Suggested change

if (retryAfter.Delta.Value.TotalMilliseconds > int.MaxValue)

{

retryPeriod = int.MaxValue;

}

else

{

retryPeriod = Convert.ToInt32(retryAfter.Delta.Value.TotalMilliseconds);

}

double totalMilliseconds = retryAfter.Delta.Value.TotalMilliseconds;

retryPeriod = totalMilliseconds > int.MaxValue

? int.MaxValue

: Convert.ToInt32(totalMilliseconds);

codecov · 2026-01-27T23:53:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.41%. Comparing base (16a3cd8) to head (ea41b39).
⚠️ Report is 11 commits behind head on dev/paul/azure/step3.

Additional details and impacted files

@@                   Coverage Diff                    @@
##           dev/paul/azure/step3    #3917      +/-   ##
========================================================
- Coverage                 69.78%   67.41%   -2.38%     
========================================================
  Files                       260      260              
  Lines                     65694    65691       -3     
========================================================
- Hits                      45844    44284    -1560     
- Misses                    19850    21407    +1557

Flag	Coverage Δ
netcore	`67.38% <ø> (-2.36%)`	⬇️
netfx	`66.43% <ø> (-2.55%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

paulmedynski added 5 commits January 26, 2026 13:03

Fixed pipeilne issues for ADO.Net pipelines.

973baff

Fixed AKV pipeline errors in the ADO.Net pipelines.

65e20a4

Added missing Abstractions package version to MDS NuGet generation.

d7b8125

Fixed official pipeline validation artifact download.

9939c15

Addressed comments from Copilot in previous PRs.

ea41b39

paulmedynski requested a review from a team as a code owner January 27, 2026 19:47

Copilot AI review requested due to automatic review settings January 27, 2026 19:47

Copilot started reviewing on behalf of paulmedynski January 27, 2026 19:47 View session

This was referenced Jan 27, 2026

Azure Split - Step 3 - Tie Everything Together #3908

Open

Azure Split - Step 2 - New Files #3904

Open

Azure Split - Step 1 - Prep Work #3902

Open

[DO NOT MERGE] Visuazlie diffs of feat/azure split #3901

Draft

Copilot AI reviewed Jan 27, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Azure Split - Step 4 - Cleanup #3917

Azure Split - Step 4 - Cleanup #3917

paulmedynski commented Jan 27, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

codecov bot commented Jan 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-/// <param name="str">The string to check; must not be null</param>
-internal static class StringExtensions
-{
+internal static class StringExtensions
+{
+    /// <summary>
+    /// Determines whether the specified string is empty without performing a null check.
+    /// </summary>
+    /// <param name="str">The string to check; must not be null.</param>
+    /// <returns><see langword="true"/> if the string is empty; otherwise, <see langword="false"/>.</returns>

	Write-Host "##vso[task.setvariable variable=CDP_BUILD_TYPE_COPY;isOutput=true]$($env:CDP_BUILD_TYPE)"
	Write-Host "##vso[task.setvariable variable=CDP_BUILD_TYPE_COPY;isOutput=true]$($env:CDP_BUILD_TYPE)"
	name: GetBuildType

-                        if (retryAfter.Delta.Value.TotalMilliseconds > int.MaxValue)
-                        {
-                            retryPeriod = int.MaxValue;
-                        }
-                        else
-                        {
-                            retryPeriod = Convert.ToInt32(retryAfter.Delta.Value.TotalMilliseconds);
-                        }
+                        double totalMilliseconds = retryAfter.Delta.Value.TotalMilliseconds;
+                        retryPeriod = totalMilliseconds > int.MaxValue
+                            ? int.MaxValue
+                            : Convert.ToInt32(totalMilliseconds);

Azure Split - Step 4 - Cleanup #3917

Are you sure you want to change the base?

Azure Split - Step 4 - Cleanup #3917

Conversation

paulmedynski commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 27, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

paulmedynski commented Jan 27, 2026 •

edited

Loading