-
Notifications
You must be signed in to change notification settings - Fork 288
Remove Linux Tiger Runtime job #5096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Removes the Linux “Tiger” runtime perf job from the runtime perf pipeline configuration to reduce overlapping coverage with Viper machines (per related PR #5095).
Changes:
- Deleted the
perftigerCoreCLR microbenchmarks job block from the runtime perf jobs template.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # run coreclr perfviper microbenchmarks perf job | ||
| - template: /eng/pipelines/common/platform-matrix.yml@${{ parameters.runtimeRepoAlias }} | ||
| parameters: |
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After removing the PerfTiger microbenchmarks job, the tigerMicro template parameter (defined near the top of this file) is no longer referenced anywhere in runtime-perf-jobs.yml. This makes the template API misleading for callers. Consider removing tigerMicro (and updating any external callers) or clearly deprecating it (e.g., comment + set default enabled: false) so it doesn’t look like a supported switch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, we should do a cleanup of all old/unused code in the near term, but that will be a different PR.
DrewScoggins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Errors are unrelated. It is a mix of Crypto errors being hit on VMs and some net10 errors due to a version not being available: |
Remove Linux Tiger Runtime job
Related: #5095