Fixed guard scroll causing engine yard deploy failure due to inconsistent gems between dev & prod#30
Open
allangrant wants to merge 53 commits intodrnic:masterfrom
Open
Fixed guard scroll causing engine yard deploy failure due to inconsistent gems between dev & prod#30allangrant wants to merge 53 commits intodrnic:masterfrom
allangrant wants to merge 53 commits intodrnic:masterfrom
Conversation
…is generated, instead of each time in the gemfile; otherwise it fails deploy scripts that check the bundle on a server with a different os than dev
Owner
|
I never saw this because I wasn't using notifications locally and had commented out those lines. I'll test this out for the next release. Thanks! |
Collaborator
|
@allangrant, I'm confused about why this change actually fixes anything. There may be a better solution. Let's chat. |
Author
|
@thommahoney Definitely open to better solutions. This change at least fixes the problem by making sure the Gemfile is interpreted the same way when it's read on production and in development that are different OS. With the switch on the operating in the Gemfile, it looks like Gemfile.lock hasn't been updated when Gemfile.lock is generated on a different operating system - because even gems that are only used in development are included in the lock file. |
…a recent git diff: scroll memorize NEW_SCROLL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guard scroll put some code in the Gemfile like this:
This caused problems when deploying to Engine Yard (or any system with a different os than the development machine) because the expected gems weren't in the lock file.
This patch moves the switch to occur when the app is created. (A scroll is usually cast in the development environment, right?)
It only puts one set of gems in the gemfile and fixes Engine Yard deploy. Output in Gemfile (for a mac system):