LocationRelay: Overload Constructor with option for LOCATION_ACCURACY_THRESHOLD Option#484
Closed
lordneeko wants to merge 3 commits intodronekit:developfrom
Closed
LocationRelay: Overload Constructor with option for LOCATION_ACCURACY_THRESHOLD Option#484lordneeko wants to merge 3 commits intodronekit:developfrom
lordneeko wants to merge 3 commits intodronekit:developfrom
Conversation
for LOCATION_ACCURACY_THRESHOLD Option
fix constructor
LocationRelay: Overload Constructor with option
Author
|
Would love to see movement in this repo... |
Collaborator
|
You've made your change against a very old commit in the repo. It would be better if you applied for changes to HEAD of develop. (I know they are small, but it means you will get proper credit in the git history by doing that) NOTE: its's good to submit one commit for this change you can use 'squash' to help you. If you need help send me a message and I can help. Thx 👍 |
Author
|
I committed against the LocationRelay file in the develop branch, which shows it is the branch with the latest changes... i don't understand how that's a very old commit. |
Collaborator
|
Sorry, my mistake. I have crated a new Pull Request with a only one commit for the change to make it easier to review the complete change see #485 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea here is to keep current compatibility, but create ability for the LocationRelay class to be used with a "Desired Accuracy" value. It may be more or less accurate than the default (10.0f) but it gives the user the option based on their needs.