Update __init__.py-line no: 2920, class Command argument message type…#1204
Closed
RedWvn wants to merge 1 commit intodronekit:masterfrom
Closed
Update __init__.py-line no: 2920, class Command argument message type…#1204RedWvn wants to merge 1 commit intodronekit:masterfrom
RedWvn wants to merge 1 commit intodronekit:masterfrom
Conversation
… changed to message_item_int
Contributor
|
Thanks. This looks great, but same fix in #1209 is more complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Command class in init.py uses mavutil.mavlink.MAVLink_mission_item_message for the message type, which uses the less accurate float32 for sending the long and lat parameters. This can be made more accurate if we use the mavutil.mavlink.MAVLink_mission_item_int_message type which uses int32 for sending, and is the recommended implementation. Hence, for the Command class, we have changed the message type to message_item_int since message_item is now depreciated.