Skip to content

Remove xfail annotations from passing tests #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evertlammerts merged 1 commit into from
Feb 5, 2026
Merged

Remove xfail annotations from passing tests #296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/fast/test_filesystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,10 @@ def add_file(fs, filename=FILENAME):


class TestPythonFilesystem:
@pytest.mark.xfail(reason="Unregister support was removed. Should be added back before release.")
def test_unregister_non_existent_filesystem(self, duckdb_cursor: DuckDBPyConnection):
with pytest.raises(InvalidInputException):
duckdb_cursor.unregister_filesystem("fake")

@pytest.mark.xfail(reason="Unregister support was removed. Should be added back before release.")
def test_memory_filesystem(self, duckdb_cursor: DuckDBPyConnection, memory: fsspec.AbstractFileSystem):
duckdb_cursor.register_filesystem(memory)

Expand Down
Loading