Handle Switchs with restricted ports#41
Open
cclose wants to merge 3 commits intodwighthubbard:masterfrom
Open
Conversation
If the switch does not let you have access to all ports and the port you do have access to has an index larger than the number of ports the switch let's you see, it will throw an exception. Example: I had a switch that only gave me port 5. Even when specifying the port directly, the script would bomb out because it believed i was asking for a port out of range. Doing the explicit compare on port number avoids this issue.
Update dlipower.py
Fixing Syntax Error
ztaira
added a commit
to ztaira/zt_dlipower
that referenced
this pull request
Feb 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a switch does not let the user have access to all ports, the switch can crash trying to access the port.
If the port the user has access to has a numeric value greater than the total number of ports it has access to, the script throws an exception.
Instead of naively comparing switch port to switchs length, we iterate all ports and compare number.
Example:
Switch grants the user access to Port 5 only.
PowerSwitch.repr displays the port correctly.
PowerSwitch.status(5) or PowerSwitch.status('name') throws exception stating port is out of range.