Issue 55 - AttributeError is raised due to request being None#56
Open
myronwalkersonos wants to merge 2 commits intodwighthubbard:masterfrom
Open
Issue 55 - AttributeError is raised due to request being None#56myronwalkersonos wants to merge 2 commits intodwighthubbard:masterfrom
myronwalkersonos wants to merge 2 commits intodwighthubbard:masterfrom
Conversation
The request.status_code line is only valid if request is not null, this line belongs in the for loop where request can potentially have meaning when it is not None but has a failing status code.
Move to out of loop but inside of an if check so we don't log too much.
ztaira
added a commit
to ztaira/zt_dlipower
that referenced
this pull request
Feb 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only try to ouput the status code for request if request is not None