Fix outlet ranges for names with dashes#57
Open
sstallion wants to merge 1 commit intodwighthubbard:masterfrom
Open
Fix outlet ranges for names with dashes#57sstallion wants to merge 1 commit intodwighthubbard:masterfrom
sstallion wants to merge 1 commit intodwighthubbard:masterfrom
Conversation
sstallion
force-pushed
the
sstallion/outlet_range
branch
from
a893c61 to
0369e06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug in
_block_to_listthat fails if an outlet name contains a-. The following changes will attempt to treat any block element that contains a-as a numeric range. If there is an issue converting this to a numeric expression, it is then treated as a string.This is particularly useful for me since my outlets are named after the hostname for the machine under control. This comes in handy during development when I need to cycle a machine using
dlipower cycle hostname-with-dashes.