Verify the challenge file exists before asking user to input randomness.#7
Open
bitcartel wants to merge 1 commit intoebfull:masterfrom
Open
Verify the challenge file exists before asking user to input randomness.#7bitcartel wants to merge 1 commit intoebfull:masterfrom
bitcartel wants to merge 1 commit intoebfull:masterfrom
Conversation
ebfull
requested changes
Mar 23, 2018
|
|
||
| // Check that the user placed the challenge file into the local directory | ||
| if !Path::new("./challenge").exists() { | ||
| println!("Error: ./challenge file not found."); |
Owner
There was a problem hiding this comment.
panic! here would suffice instead of pulling in std::process.
Author
There was a problem hiding this comment.
The idea here is that a regular error message is better for users, rather than a scary panic message.
If the compute binary is to be as bare bones as possible, where fewer dependencies is deemed better, I can change to panic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.