Set up SSHD service entirely within sshd.start. #2066
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrunber
requested review from
SDawley,
dkwon17,
ibuziuk,
mkuznyetsov and
tolusha
as code owners
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rgrunber The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
rgrunber
commented
Dec 3, 2025
The start process works as follows : 1. che-code-sshd-page component starts and copies all relevant resources (/usr/sbin/sshd, /usr/bin/ssh-keygen, /usr/lib64/libnss_wrapper.so /etc/ssh/sshd_config, sshd.start) into the /sshd volume mount. 2. che-code-sshd-page waits for existence of a file (/sshd/username) to be created. Once created, it can generate the landing page and instructions 3. che-code-sshd component configuration gets merged into the tool container and runs the /sshd/sshd.start command from the shared mount. This sets up the SSHD service. 4. Once the SSHD service is started, the /sshd mount will have the username needed for the landing page connection instructions, and the che-code-sshd-page will open Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber
force-pushed
the
sshd-injector
branch
from
16b0a20 to
d95a19a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires che-incubator/che-code#606 (for the component portion)
The start process works as follows :
I've tested
ubi8,ubi9,ubi10images and they seem to work well. Most images based on those should work.Things left to do :
quay.io/devfile/base-developer-image, quay.io/devfile/universal-developer-image) don't work but there is a solution, I just haven't added yet