This repository was archived by the owner on Feb 13, 2022. It is now read-only.
Changes as not to leak readLine into global#36
Open
pipobscure wants to merge 1 commit intoelbart:masterfrom
pipobscure:dontleakreadline
Open
Changes as not to leak readLine into global#36pipobscure wants to merge 1 commit intoelbart:masterfrom pipobscure:dontleakreadline
pipobscure wants to merge 1 commit intoelbart:masterfrom
pipobscure:dontleakreadline
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
you are leaking the function readLine into the global object. That's not a good thing, because you don't know who else is doing so. It will break your and other code when mixed in unpredictable ways.