Skip to content

chore: move electron to devDependencies and bump to 34.1.0, remove unstable loadingView test case #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WynterDing merged 2 commits into from
Jan 13, 2026
Merged

chore: move electron to devDependencies and bump to 34.1.0, remove unstable loadingView test case #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4a7270
chore: move electron to devDependencies and bump to 34.1.0 (#1)
Copilot Jan 12, 2026
4ae5216
Remove unstable loadingView test and ignore package-lock.json (#2)
Copilot Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "electron-windows",
"version": "34.0.0",
"version": "34.1.0",
"description": "Manage multiple windows of Electron gracefully and provides powerful features.",
"keywords": [
"electron",
Expand All @@ -18,14 +18,14 @@
"url": "git://github.com/electron-modules/electron-windows.git"
},
"dependencies": {
"electron": "34",
"electron-window-state": "^5.0.3",
"lodash": "4"
},
"devDependencies": {
"@babel/eslint-parser": "^7.27.1",
"@playwright/test": "^1.52.0",
"@types/node": "^22.15.17",
"electron": "34",
Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The electron package should be specified as a peerDependency rather than a devDependency. The library code requires electron at runtime (see lib/electron-windows.js line 4: require('electron')). This is a utility library for Electron apps, so electron should be provided by the consuming application. Consider adding it to peerDependencies instead and keeping it in devDependencies for development/testing purposes.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The electron version specification "34" is too loose and non-standard. It should use a proper semver range like "^34.0.0" or ">=34.0.0 <35.0.0" to ensure compatibility and follow npm best practices. The shorthand "34" is equivalent to ">=34.0.0 <35.0.0" but is less clear and not commonly used in modern npm packages.

Suggested change
"electron": "34",
"electron": ">=34.0.0 <35.0.0",

Copilot uses AI. Check for mistakes.
"electron-json-storage-alt": "18",
"eslint": "7",
"eslint-config-egg": "12",
Expand Down
7 changes: 0 additions & 7 deletions test/e2e/electron-windows.e2e.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,6 @@ test.describe('test/e2e/electron-windows.e2e.test.js', () => {
electronApp = await electron.launch({ args: ['start.js'], cwd: path.join(__dirname, '../..') });
});

test('loadingView option is working', async () => {
const window = await electronApp.firstWindow();

expect(await window.title()).toBe('Loading');
expect(window.url()).toMatch(/renderer\/loading\.html$/);
});

test('new window can be correctly created', async () => {
await wait();
const window = await electronApp.firstWindow();
Expand Down