ensure all handlers respond with a status code, rather than rely on t…#183
Open
iwarapter wants to merge 1 commit intoelimity-com:masterfrom
Open
ensure all handlers respond with a status code, rather than rely on t…#183iwarapter wants to merge 1 commit intoelimity-com:masterfrom
iwarapter wants to merge 1 commit intoelimity-com:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When wrapping the server handler with a logging middleware, e.g:
because most of the underlying handlers rely on the http.Server defaulting the status at the very end - it is not possible to correctly get the status for endpoints which return a status 200.
This change just ensures a consistently setting the http status from all handlers.