WIP: improve EDDB download and update times#23
Draft
chennin wants to merge 8 commits intoelite-kode:masterfrom
Draft
WIP: improve EDDB download and update times#23chennin wants to merge 8 commits intoelite-kode:masterfrom
chennin wants to merge 8 commits intoelite-kode:masterfrom
Conversation
chennin
commented
Nov 15, 2021
| updateOne: { | ||
| filter: { | ||
| id: json.id, | ||
| // updated_at: { $ne: json.updated_at } |
Author
There was a problem hiding this comment.
this is commented out because otherwise, Mongo returns a duplicate key error for every record NOT updated. It still updates any changed field, eg 0 inserted, 1000 matched, 1 modified, 0 upserted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches to bulk Mongo updates. On my 2CPU/2GB test VM, factions download and update goes from 90s to 7s. However, systems update is still unable to complete, and the others take about 10 minutes each.
Disclaimer: literally never touched Node before
On a better 4CPU/8GB test VM, I get:
commodity: ~6m 15s
factions: ~5s
stations: ~6m45s
populatedSystems: ~45s
...
TODO: bulkWrite does not invoke middleware. Check on the other middleware in the models and copy them.