Extract input data and output rendering to separates files#3
Open
Extract input data and output rendering to separates files#3
Conversation
patcon
reviewed
Dec 30, 2024
Comment on lines
+22
to
+23
| vote_map = {'agree': 1, 'disagree': -1} | ||
| votes = [[vote_map.get(v, 0) for v in user_votes] |
Collaborator
There was a problem hiding this comment.
Suggested change
| vote_map = {'agree': 1, 'disagree': -1} | |
| votes = [[vote_map.get(v, 0) for v in user_votes] | |
| vote_map = {'agree': 1, 'disagree': -1, 'pass': 0} | |
| votes = [[vote_map.get(v) for v in user_votes] |
To be more explicit about when something unexpected happens, and avoid dividing assumptions between two lines :)
patcon
reviewed
Dec 30, 2024
| Divisive Statements: | ||
| {%- for stmt, agree in divisive_data %} | ||
| {%- if agree >= 0.5 %} | ||
| - {{ stmt }} |
Collaborator
There was a problem hiding this comment.
Should we print a numerical value to better see when things change in output?
patcon
reviewed
Dec 30, 2024
| Consensus Statements: | ||
| {%- for stmt, score, agree in consensus_data %} | ||
| {%- if agree < 0.5 %} | ||
| - {{ stmt }} ({{ 'strong agreement' if score > 0.5 else 'strong disagreement' }}) |
Collaborator
There was a problem hiding this comment.
Should we print a numerical value to better see when things change in output?
patcon
reviewed
Dec 30, 2024
| {%- for grp_id, positions in group_data.items() %} | ||
| Group {{ grp_id }} characteristics: | ||
| {%- for stmt, opinion in positions %} | ||
| - {{ 'strongly agrees with' if opinion > 0 else 'strongly disagrees with' }}: {{ stmt }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to extract some noisy details while keeping readability.