Never output a leading comma before non-transactional messages#101
Open
gclinch wants to merge 1 commit intoeulerto:masterfrom
gclinch:nr_changes
Open
Never output a leading comma before non-transactional messages#101gclinch wants to merge 1 commit intoeulerto:masterfrom gclinch:nr_changes
gclinch wants to merge 1 commit intoeulerto:masterfrom
gclinch:nr_changes
Conversation
Author
|
wal2json generates invalid json when a non-transactional message is received immediately after a transaction commit if the transaction contained more than one change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-transactional messages can arrive after a transaction commit but before the next begin. nr_changes is only reset to zero in begin_txn. Perhaps it would be safer to reset nr_changes in commit_txn instead?