This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Fix pip install . by adding empty py_modules#226
Open
xhluca wants to merge 1 commit intofacebookresearch:mainfrom
Open
Fix pip install . by adding empty py_modules#226xhluca wants to merge 1 commit intofacebookresearch:mainfrom
pip install . by adding empty py_modules#226xhluca wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
Author
|
I can also include a fix for #147 based on the stackoveflow thread: https://stackoverflow.com/a/53383704 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following step:
This issue was originally reported in: #223
@AkariAsai proposed the following fix: #223 (comment)
This PR simply implements the proposed fix as is, and it successfully corrects the reported error