Add query runs method

[eliasbenussi]

No description provided.

[tommilata]

It'd be nice to change delete_run and restore_runs to use the new schema too. I appreciate it's extra work, but I think it's worth it for the sake of consistency.

[tommilata]

Did you consider using a library for the polymorphic filter type? E.g. https://github.com/marshmallow-code/marshmallow-oneofschema or https://github.com/Bachmann1234/marshmallow-polyfield. (I'm not saying we need to use it).

[tommilata]

Well done, it guess it must be quite fiddly to write custom marshmallow schemas... I left a few comments. Also I'm not sure about marshmallow best practices around polymorphic types, so someone else's opinion might be useful.

[eliasbenussi]

It'd be nice to change delete_run and restore_runs to use the new schema too. I appreciate it's extra work, but I think it's worth it for the sake of consistency.

@tomas-milata I agree that we should do it, but I was considering doing it in a separate PR. My reasoning is that the query_runs function we implemented was required in @acroz 's PR (#106) and so I would just like to get it out as soon as it's ready.

In fact I would say that, other than delete_runs and restore_runs, we could also reimplement list_runs to internally call query_runs as it is just a special case at this point -- although possibly a convenient one to have

[eliasbenussi]

Did you consider using a library for the polymorphic filter type? E.g. https://github.com/marshmallow-code/marshmallow-oneofschema or https://github.com/Bachmann1234/marshmallow-polyfield. (I'm not saying we need to use it).

@tomas-milata I did not, but I after taking a look I think that:

• the first one leads to a decoding that is unfortunately not correct for our payload (it explicitly specifies the type of the object). It adds a type field (although I think this can be removed), and it names the key for the value according to its type. Neither of these things are what we want.

• the second one still requires to explicitly implement serialisation and deserialisation functions. This is verbose enough that I think our current implementation is basically just as good, with the advantage of one less dependency

[eliasbenussi]

Did you consider using a library for the polymorphic filter type? E.g. https://github.com/marshmallow-code/marshmallow-oneofschema or https://github.com/Bachmann1234/marshmallow-polyfield. (I'm not saying we need to use it).

@tomas-milata I did not, but I after taking a look I think that:

• the first one leads to a decoding that is unfortunately not correct for our payload (it explicitly specifies the type of the object). It adds a type field (although I think this can be removed), and it names the key for the value according to its type. Neither of these things are what we want.
• the second one still requires to explicitly implement serialisation and deserialisation functions. This is verbose enough that I think our current implementation is basically just as good, with the advantage of one less dependency

Actually I think my points on the first one are wrong. That one might be a viable solution

[acroz]

What does skip_if do? I can't find any mention of it in the documentation.

[haileyfong]

I think this was added by mistake as all tests passed when I tried removing it. Thanks for spotting this out, I will remove it now.

Changes made, want to merge.