marshmallow schema maintenance to address RemovedInMarshmallow4Warning results#203
marshmallow schema maintenance to address RemovedInMarshmallow4Warning results#203
Conversation
|
Hey, thanks for this update. Looking at the changelog, it looks like For the sake of completeness, your other updates depend on earlier updates to the API (make_error: 3.0.0, self -> lambda: 3.3.0) so an updated min version to 3.13.0 should cover all. |
|
@acroz that's a good shout, didn't think of that aspect! Given that the release is almost 1 year old, it should be on the safe territory, but I'll check for any side-effects or other considerations, and add the minimum version if it looks okay. Will reping when that's done. |
|
@acroz did the update here because it is sensible, tried installing in the platform with pip install git+https://github.com/facultyai/faculty.git@schema-maintenance#egg=facultyand that shows a bit of legacy issue: I guess that needs a bit of deprecation/transition out process? |
Since the dependency list do not limit the
marshmallowversion, it is likely prudent to fix the multitude ofRemovedInMarshmallow4Warningresults that the tests are throwing. Most of them are pretty straightforward, but happy to elaborate.Tests were run with
tox -e py38 -- -Werrorto make warnings into errors for the process.There's one remaining warning that is coming from the
marshmallow_enumlibrary, and #202 should be relevant for this.