Refactor: Remove unsafe blocks in biology and fix unwrap in clinical trials#441
Refactor: Remove unsafe blocks in biology and fix unwrap in clinical trials#441
Conversation
…trials
- Refactored `FiniteDifference1D` in `biology/diffusion.rs` to use safe `windows(3)` and `zip` iterators instead of `unsafe` manual indexing.
- Refactored `TuringSystem::step` in `biology/morphogenesis.rs` to use safe `zip` iterators for fused multiply-add operations, removing `unsafe` blocks.
- Replaced `unwrap()` with `expect("...")` in `simple_randomization` in `applied/clinical_trials/design.rs` to provide safer error messages for deprecated code.
- Verified changes with `cargo test`.
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR addresses critical safety and code quality issues identified during the Refactor audit.
unsafeblocks frommath_explorer/src/biology/diffusion.rsandmath_explorer/src/biology/morphogenesis.rs. The optimized sliding window and fused multiply-add logic were preserved using safe Rust iterators (windows,zip).unwrap()inmath_explorer/src/applied/clinical_trials/design.rswithexpect()containing a descriptive message, as per legacy code guidelines.All regression tests passed.
PR created automatically by Jules for task 4687207953436668645 started by @fderuiter