Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables strong-name signing of assemblies to support legacy .NET Framework compatibility. The keypair is intentionally included in the repository without security guarantees, with plans to remove this feature when .NET Framework support becomes too burdensome to maintain.
Key changes:
- Added strong-name signing configuration via
Directory.Build.propsfiles - Updated
InternalsVisibleToattribute to include the public key for the signed test assembly - Corrected project structure by moving benchmark project path references
Reviewed Changes
Copilot reviewed 6 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Directory.Build.props | Root configuration file enabling assembly signing for all projects |
| src/Directory.Build.props | Imports parent signing configuration for source projects |
| test/Directory.Build.props | Imports parent signing configuration for test projects |
| src/F23.StringSimilarity/Properties/AssemblyInfo.cs | Updated InternalsVisibleTo with public key for signed test assembly |
| test/F23.StringSimilarity.Benchmarks/F23.StringSimilarity.Benchmarks.csproj | Fixed project reference path to correct location |
| F23.StringSimilarity.sln | Corrected benchmark project path in solution file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41
Note that this does not provide any security guarantees, as the keypair is included in the repo on purpose. This is solely for legacy .NET Framework compatibility for use cases that require it.
Our intention is to drop this in a future version when .NET Framework support is too difficult to maintain.