[Fix] Notification 잘못된 요청 응답 시, 방어적 로직 작성

app/src/main/java/com/daedan/festabook/data/datasource/remote/festival/FestivalNotificationDataSource.kt

@@ -2,6 +2,7 @@ package com.daedan.festabook.data.datasource.remote.festival
 
 import com.daedan.festabook.data.datasource.remote.ApiResult
 import com.daedan.festabook.data.model.response.festival.FestivalNotificationResponse
+import com.daedan.festabook.data.model.response.festival.RegisteredFestivalNotificationResponse
 
 interface FestivalNotificationDataSource {
     suspend fun saveFestivalNotification(
@@ -10,4 +11,6 @@ interface FestivalNotificationDataSource {
     ): ApiResult<FestivalNotificationResponse>
 
     suspend fun deleteFestivalNotification(festivalNotificationId: Long): ApiResult<Unit>
+
+    suspend fun getFestivalNotification(deviceId: Long): ApiResult<List<RegisteredFestivalNotificationResponse>>
 }

app/src/main/java/com/daedan/festabook/data/datasource/remote/festival/FestivalNotificationDataSourceImpl.kt

@@ -3,6 +3,7 @@ package com.daedan.festabook.data.datasource.remote.festival
 import com.daedan.festabook.data.datasource.remote.ApiResult
 import com.daedan.festabook.data.model.request.FestivalNotificationRequest
 import com.daedan.festabook.data.model.response.festival.FestivalNotificationResponse
+import com.daedan.festabook.data.model.response.festival.RegisteredFestivalNotificationResponse
 import com.daedan.festabook.data.service.FestivalNotificationService
 import dev.zacsweers.metro.AppScope
 import dev.zacsweers.metro.ContributesBinding
@@ -28,4 +29,9 @@ class FestivalNotificationDataSourceImpl(
         ApiResult.toApiResult {
             festivalNotificationService.deleteFestivalNotification(festivalNotificationId)
         }
+
+    override suspend fun getFestivalNotification(deviceId: Long): ApiResult<List<RegisteredFestivalNotificationResponse>> =
+        ApiResult.toApiResult {
+            festivalNotificationService.getFestivalNotification(deviceId)
+        }
 }

app/src/main/java/com/daedan/festabook/data/model/response/festival/RegisteredFestivalNotificationResponse.kt

@@ -0,0 +1,16 @@
+package com.daedan.festabook.data.model.response.festival
+
+import kotlinx.serialization.SerialName
+import kotlinx.serialization.Serializable
+
+@Serializable
+data class RegisteredFestivalNotificationResponse(
+    @SerialName("festivalNotificationId")
+    val festivalNotificationId: Long,
+    @SerialName("festivalId")
+    val festivalId: Long,
+    @SerialName("universityName")
+    val universityName: String,
+    @SerialName("festivalName")
+    val festivalName: String,
+)

app/src/main/java/com/daedan/festabook/data/repository/FestivalNotificationRepositoryImpl.kt

@@ -9,7 +9,6 @@ import com.daedan.festabook.domain.repository.FestivalNotificationRepository
 import dev.zacsweers.metro.AppScope
 import dev.zacsweers.metro.ContributesBinding
 import dev.zacsweers.metro.Inject
-import timber.log.Timber
 
 @ContributesBinding(AppScope::class)
 @Inject
@@ -20,43 +19,73 @@ class FestivalNotificationRepositoryImpl(
     private val festivalLocalDataSource: FestivalLocalDataSource,
 ) : FestivalNotificationRepository {
     override suspend fun saveFestivalNotification(): Result<Unit> {
-        val deviceId = deviceLocalDataSource.getDeviceId()
-        if (deviceId == null) {
-            Timber.e("${::FestivalNotificationRepositoryImpl.name}: DeviceId가 없습니다.")
-            return Result.failure(IllegalStateException())
-        }
-        val festivalId = festivalLocalDataSource.getFestivalId()
+        val deviceId =
+            deviceLocalDataSource.getDeviceId() ?: return Result.failure(
+                IllegalArgumentException(NO_DEVICE_ID_EXCEPTION),
+            )
+        val festivalId =
+            festivalLocalDataSource.getFestivalId() ?: return Result.failure(
+                IllegalArgumentException(NO_FESTIVAL_ID_EXCEPTION),
+            )
 
-        val result =
-            festivalId?.let {
-                festivalNotificationDataSource
-                    .saveFestivalNotification(
-                        festivalId = it,
-                        deviceId = deviceId,
-                    ).toResult()
-            }
-                ?: throw IllegalArgumentException("${::FestivalNotificationRepositoryImpl.javaClass.simpleName}festivalId가 null 입니다.")
-        return result
-            .mapCatching {
+        return festivalNotificationDataSource
+            .saveFestivalNotification(
+                festivalId = festivalId,
+                deviceId = deviceId,
+            ).toResult()
+            .mapCatching { response ->
                 festivalNotificationLocalDataSource.saveFestivalNotificationId(
                     festivalId,
-                    it.festivalNotificationId,
+                    response.festivalNotificationId,
                 )
             }
     }
 
     override suspend fun deleteFestivalNotification(): Result<Unit> {
         val festivalId =
-            festivalLocalDataSource.getFestivalId() ?: return Result.failure(
-                IllegalStateException(),
-            )
+            festivalLocalDataSource.getFestivalId()
+                ?: return Result.failure(IllegalStateException(NO_FESTIVAL_ID_EXCEPTION))
         val festivalNotificationId =
             festivalNotificationLocalDataSource.getFestivalNotificationId(festivalId)
-        val response =
-            festivalNotificationDataSource.deleteFestivalNotification(festivalNotificationId)
-        festivalNotificationLocalDataSource.deleteFestivalNotificationId(festivalId)
+        return festivalNotificationDataSource
+            .deleteFestivalNotification(festivalNotificationId)
+            .toResult()
+            .mapCatching {
+                festivalNotificationLocalDataSource.deleteFestivalNotificationId(festivalId)
+            }
+    }
+
+    override suspend fun syncFestivalNotificationIsAllow(): Result<Boolean> {
+        val deviceId =
+            deviceLocalDataSource.getDeviceId() ?: return Result.failure(
+                IllegalArgumentException(NO_DEVICE_ID_EXCEPTION),
+            )
+        val festivalId =
+            festivalLocalDataSource.getFestivalId() ?: return Result.failure(
+                IllegalArgumentException(NO_FESTIVAL_ID_EXCEPTION),
+            )
 
-        return response.toResult()
+        return festivalNotificationDataSource
+            .getFestivalNotification(deviceId)
+            .toResult()
+            .mapCatching { response ->
+                val notificationId =
+                    response.find { it.festivalId == festivalId }?.festivalNotificationId
+                val isSubscribed = notificationId != null
+                festivalNotificationLocalDataSource.saveFestivalNotificationIsAllowed(
+                    festivalId,
+                    isSubscribed,
+                )
+                if (isSubscribed) {
+                    festivalNotificationLocalDataSource.saveFestivalNotificationId(
+                        festivalId,
+                        notificationId,
+                    )
+                } else {
+                    festivalNotificationLocalDataSource.deleteFestivalNotificationId(festivalId)
+                }
+                isSubscribed
+            }
     }
 
     override fun getFestivalNotificationIsAllow(): Boolean {
@@ -72,4 +101,11 @@ class FestivalNotificationRepositoryImpl(
             )
         }
     }
+
+    companion object {
+        private val NO_FESTIVAL_ID_EXCEPTION =
+            "${::FestivalNotificationRepositoryImpl.name}: FestivalId가 없습니다."
+        private val NO_DEVICE_ID_EXCEPTION =
+            "${::FestivalNotificationRepositoryImpl.name}: DeviceId가 없습니다."
+    }
 }

app/src/main/java/com/daedan/festabook/data/service/FestivalNotificationService.kt

@@ -2,9 +2,11 @@ package com.daedan.festabook.data.service
 
 import com.daedan.festabook.data.model.request.FestivalNotificationRequest
 import com.daedan.festabook.data.model.response.festival.FestivalNotificationResponse
+import com.daedan.festabook.data.model.response.festival.RegisteredFestivalNotificationResponse
 import retrofit2.Response
 import retrofit2.http.Body
 import retrofit2.http.DELETE
+import retrofit2.http.GET
 import retrofit2.http.POST
 import retrofit2.http.Path
 
@@ -19,4 +21,9 @@ interface FestivalNotificationService {
     suspend fun deleteFestivalNotification(
         @Path("festivalNotificationId") id: Long,
     ): Response<Unit>
+
+    @GET("festivals/notifications/{deviceId}")
+    suspend fun getFestivalNotification(
+        @Path("deviceId") id: Long,
+    ): Response<List<RegisteredFestivalNotificationResponse>>
 }

app/src/main/java/com/daedan/festabook/domain/repository/FestivalNotificationRepository.kt

@@ -5,6 +5,8 @@ interface FestivalNotificationRepository {
 
     suspend fun deleteFestivalNotification(): Result<Unit>
 
+    suspend fun syncFestivalNotificationIsAllow(): Result<Boolean>
+
     fun getFestivalNotificationIsAllow(): Boolean
 
     fun setFestivalNotificationIsAllow(isAllowed: Boolean)

app/src/main/java/com/daedan/festabook/presentation/setting/SettingViewModel.kt

@@ -44,6 +44,16 @@ class SettingViewModel(
 
     val success = _success.asSharedFlow()
 
+    init {
+        viewModelScope.launch {
+            festivalNotificationRepository
+                .syncFestivalNotificationIsAllow()
+                .onSuccess {
+                    _isAllowed.emit(it)
+                }
+        }
+    }
+
     fun notificationAllowClick() {
         if (!_isAllowed.value) {
             viewModelScope.launch {