Skip to content

[WIP] flamenco, runtime: implement commission_rate_in_basis_points#8161

Open
topointon-jump wants to merge 1 commit intofiredancer-delay-commission-updatesfrom
firedancer-commission-rate-in-basis-points
Open

[WIP] flamenco, runtime: implement commission_rate_in_basis_points#8161
topointon-jump wants to merge 1 commit intofiredancer-delay-commission-updatesfrom
firedancer-commission-rate-in-basis-points

Conversation

@topointon-jump
Copy link
Contributor

@topointon-jump topointon-jump commented Feb 4, 2026

#8146

This PR is on top of #8160

  • Implementation
  • Unit tests
  • Ledger (blocked on 4.0 release)
  • Fuzzing

Don't merge before 4.0 is cut

@topointon-jump topointon-jump changed the base branch from main to firedancer-delay-commission-updates February 4, 2026 22:19
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.073634 s 0.072999 s -0.862%
backtest mainnet-368528500-perf snapshot load NaN s NaN s NaN%
backtest mainnet-368528500-perf total elapsed 73.634455 s 72.998738 s -0.863%
firedancer mem usage with mainnet.toml 1069.34 GiB 1069.34 GiB 0.000%

@topointon-jump topointon-jump force-pushed the firedancer-commission-rate-in-basis-points branch from 97ddfb4 to fc95717 Compare February 4, 2026 23:16
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.06213 s 0.062531 s 0.645%
backtest mainnet-368528500-perf snapshot load NaN s NaN s NaN%
backtest mainnet-368528500-perf total elapsed 62.129711 s 62.530944 s 0.646%
firedancer mem usage with mainnet.toml 1069.34 GiB 1058.31 GiB -1.031%

@topointon-jump topointon-jump force-pushed the firedancer-commission-rate-in-basis-points branch from fc95717 to 5fb1afa Compare February 4, 2026 23:22
@topointon-jump topointon-jump mentioned this pull request Feb 4, 2026
10 tasks
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.070517 s 0.070519 s 0.003%
backtest mainnet-368528500-perf snapshot load NaN s NaN s NaN%
backtest mainnet-368528500-perf total elapsed 70.516947 s 70.519164 s 0.003%
firedancer mem usage with mainnet.toml 1069.34 GiB 1058.31 GiB -1.031%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant