fix: use UNIX nanoseconds for tile_heartbeat gauge#8201
Open
N3ro47 wants to merge 1 commit intofiredancer-io:mainfrom
Open
fix: use UNIX nanoseconds for tile_heartbeat gauge#8201N3ro47 wants to merge 1 commit intofiredancer-io:mainfrom
N3ro47 wants to merge 1 commit intofiredancer-io:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #6848
Changed
tile_heartbeatto report UNIX nanoseconds usingfd_log_wallclock()instead of raw ticks.I'm still learning the tribal knowledge of the project, but my assessment is that
fd_log_wallclockis performant enough for the housekeeping path. It maps toclock_gettime(CLOCK_REALTIME), which typically utilizes the vDSO path.