[PoC] support both logrus logger and entity#188
Open
makasim wants to merge 1 commit intoflashmob:masterfrom
Open
[PoC] support both logrus logger and entity#188makasim wants to merge 1 commit intoflashmob:masterfrom
makasim wants to merge 1 commit intoflashmob:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am embedding Guerrilla SMTP server into my code and there is a need to pass Logrus Entry as a logger to the daemon. The problem is that HookedLogger accepts a Logger struct so it is not possible to pass Entry. Consider next code
I am going to add tests and fix code review comments if it makes sense to you in general and is going to be merged. Just let me know.