Closed
Conversation
suranap
reviewed
Jan 11, 2024
src/ops/kernels/dropout_kernels.cu
Outdated
| cudaStream_t stream; | ||
| checkCUDA(get_legion_stream(&stream)); | ||
| Internal::forward_kernel(m, input_ptr, output_ptr, stream); | ||
| Internal::forward_kernel(m, input.get_float_ptr(), output.get_float_ptr(), stream); |
Collaborator
There was a problem hiding this comment.
This signature does not match dropout_kernels.h, which adds another parameter: size_t num_elements
suranap
reviewed
Jan 11, 2024
src/ops/kernels/dropout_kernels.cu
Outdated
| cudaStream_t stream; | ||
| checkCUDA(get_legion_stream(&stream)); | ||
| Internal::backward_kernel(m, output_grad_ptr, input_grad_ptr, stream); | ||
| Internal::backward_kernel(m, output_grad.get_float_ptr(), input_grad.get_float_ptr(), stream); |
Collaborator
There was a problem hiding this comment.
This signature does not match dropout_kernels.h, which adds another parameter: size_t num_elements
Collaborator
Author
There was a problem hiding this comment.
Hi Pinku, I pushed some fix, please tell me if you meet any issue.
suranap
reviewed
Jan 18, 2024
Collaborator
|
@xinhaoc Should we close this PR? |
Collaborator
Author
this is the working pr of candle project, let's keep it know |
Collaborator
|
Move to flexflow/flexflow-serve#87 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Related Issues:
Linked Issues:
Issues closed by this PR:
This change is