Named validation/transformation also changes JSON Schema title#43
Open
Named validation/transformation also changes JSON Schema title#43
Conversation
Since transformNamed will inline the wrapped object, it is inintuitive that the title of the wrapped object is not updated, since it could come from e.g. unionNamed. One would expect that the outer name would override the inner one.
qxjit
requested changes
Feb 14, 2026
Member
qxjit
left a comment
qxjit
left a comment
There was a problem hiding this comment.
❤️ Thank you!
One tiny request I added, but this is a nice fix.
src/Orb/OpenApi.hs
Outdated
| , schemaComponents = components | ||
| , openApiSchema = | ||
| (openApiSchema schemaInfo) | ||
| { OpenApi._schemaTitle = Just $ fleeceNameToOpenApiKey name |
Member
There was a problem hiding this comment.
To make sure we keep matching the openApiKey value above we should extract the key to a let binding and then use it for both openApiKey and _schemaTitle
Contributor
Author
There was a problem hiding this comment.
Ok, I have pushed a commit to address this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transformNamed will inline the wrapped schema in the emitted JSON.
It is however unintuitive that the title of the wrapped object is not updated,
since it could come from e.g. unionNamed.
One would expect that the outer name would override the inner one.