Skip to content

attempted to collapse function layers in linear module, put sliding f… #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavelkomarov merged 2 commits into from
Jul 1, 2025
Merged

attempted to collapse function layers in linear module, put sliding f… #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b771e51
attempted to collapse function layers in linear module, put sliding f…
pavelkomarov Jul 1, 2025
c7af959
patching tests
pavelkomarov Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions pynumdiff/kalman_smooth/_kalman_smooth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ def constant_velocity(x, dt, params=None, options=None, r=None, q=None, forwardb
- **dxdt_hat** -- estimated derivative of x
"""
if params != None: # boilerplate backwards compatibility code
warn("""`params` and `options` parameters will be removed in a future version. Use `r`,
Copy link
Collaborator Author

@pavelkomarov pavelkomarov Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've determined these print prettier if we + single-" strings.

`q`, and `forwardbackward` instead.""", DeprecationWarning)
warn("`params` and `options` parameters will be removed in a future version. Use `r`, " +
"`q`, and `forwardbackward` instead.", DeprecationWarning)
r, q = params
if options != None:
if 'forwardbackward' in options: forwardbackward = options['forwardbackward']
Expand Down Expand Up @@ -158,8 +158,8 @@ def constant_acceleration(x, dt, params=None, options=None, r=None, q=None, forw
- **dxdt_hat** -- estimated derivative of x
"""
if params != None: # boilerplate backwards compatibility code
warn("""`params` and `options` parameters will be removed in a future version. Use `r`,
`q`, and `forwardbackward` instead.""", DeprecationWarning)
warn("`params` and `options` parameters will be removed in a future version. Use `r`, " +
"`q`, and `forwardbackward` instead.", DeprecationWarning)
r, q = params
if options != None:
if 'forwardbackward' in options: forwardbackward = options['forwardbackward']
Expand Down Expand Up @@ -197,8 +197,8 @@ def constant_jerk(x, dt, params=None, options=None, r=None, q=None, forwardbackw
- **dxdt_hat** -- estimated derivative of x
"""
if params != None: # boilerplate backwards compatibility code
warn("""`params` and `options` parameters will be removed in a future version. Use `r`,
`q`, and `forwardbackward` instead.""", DeprecationWarning)
warn("`params` and `options` parameters will be removed in a future version. Use `r`, " +
"`q`, and `forwardbackward` instead.", DeprecationWarning)
r, q = params
if options != None:
if 'forwardbackward' in options: forwardbackward = options['forwardbackward']
Expand Down Expand Up @@ -242,8 +242,8 @@ def known_dynamics(x, params, u=None, options=None, xhat0=None, P0=None, A=None,
:return: np.array **x_hat** -- estimated (smoothed) x
""" # Why not also returning derivative here?
if params != None:
warn("""`params` and `options` parameters will be removed in a future version. Use `xhat0`,
`P0`, `A`, `B`, `C`, `Q`, `R`, and `smooth` instead.""", DeprecationWarning)
warn("`params` and `options` parameters will be removed in a future version. Use `xhat0`, " +
"`P0`, `A`, `B`, `C`, `Q`, `R`, and `smooth` instead.", DeprecationWarning)
xhat0, P0, A, B, C, R, Q = params
if options != None:
if 'smooth' in options: smooth = options['smooth']
Expand Down
Loading