Merged
Conversation
Collaborator
Author
|
The Kalman methods are doing markedly worse than they used to. They're not as smooth. I've been investigating, and it's definitely something to do with my |
pavelkomarov
commented
Jul 1, 2025
| P = P_ | ||
| if not np.isnan(y[n]): | ||
| xhat = xhat_.copy() | ||
| P = P_.copy() |
Collaborator
Author
There was a problem hiding this comment.
This one was bad. Subtle. Took me a long time to find, because the old code that worked properly was so different from this updated code, so winnowing and ablating down to the issue was complicated.
pavelkomarov
commented
Jul 1, 2025
| [(-5, -6), (-4, -5), (0, -1), (0, 0)], | ||
| [(-5, -5), (-4, -4), (0, -1), (0, 0)], | ||
| [(-1, -1), (0, 0), (0, -1), (0, 0)], | ||
| [(1, 1), (2, 2), (1, 1), (2, 2)], |
Collaborator
Author
There was a problem hiding this comment.
Bounds get a lot tighter across the board with the bug fixed.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is best viewed by going to the Code section of the repo and selecting the
examples-updatebranch, then navigating to the notebook to see it rendered by GitHub. You can do the same with the prior version to compare.