Add missing imports to map_task example#1263
Open
davidmirror-ops wants to merge 2 commits intoflyteorg:masterfrom
Open
Add missing imports to map_task example#1263davidmirror-ops wants to merge 2 commits intoflyteorg:masterfrom
davidmirror-ops wants to merge 2 commits intoflyteorg:masterfrom
Conversation
Signed-off-by: davidmirror-ops <david espejo@union.ai>
davidmirror-ops
requested review from
kumare3 and
wild-endeavor
as code owners
| from typing import Tuple, List | ||
|
|
||
| from flytekit import map_task | ||
| from flytekit import map_task, task, workflow |
Contributor
There was a problem hiding this comment.
I believe these have been imported at the beginning for a different example.
Contributor
Author
There was a problem hiding this comment.
Do we want to make each example "self-contained"?
While it's true that previous examples have the import, if a user goes directly to the Map Tasks section, the example won't be complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unless I'm missing something very obvious, there's no way this example could run without the missing imports.