Skip to content

Conversation

@adrian-salas
Copy link

What this PR does / why we need it

This PR updates the Helm chart’s deployment template to respect a user-provided existingSecret for the database URI, falling back to the auto-generated secret name only if none is specified

Special notes for your reviewer

  • The change is backward-compatible: if no existingSecret is provided, the chart behaves as before

Use user-provided existingSecret for the database URI
Fall back to the auto-generated secret name if none specified
@adrian-salas adrian-salas changed the title Existing secret for linkwarden.database always fallsback to helper.tpl value fix(charts/linkwarden): Use user-defined existing secret for database Sep 18, 2025
@adrian-salas
Copy link
Author

adrian-salas commented Sep 18, 2025

Might actually be fixed by: #40

For the context, when setting values like so

linkwarden: 
  database: 
    existingSecret: "linkwarden-postgresql-app"

the deploment is set like so

spec:
  containers:
  - env:
    - name: DATABASE_URL
      valueFrom:
        secretKeyRef:
          key: uri
          name: linkwarden-db

Even when set, the value is using the helper.tpl value

@github-actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 18, 2025
@github-actions
Copy link

false

@github-actions github-actions bot closed this Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant