Conversation
Reconnection logic is now disabled when disconnect is by request (call to .end() or .destroy()).
|
Would be accepted with tests. Otherwise will wait until someone with commit access has the time to write tests, which could be several months. |
|
Well for me it could also be several months, when I'd have some time I'll Pozdrawiam 2015-02-02 18:15 GMT+01:00 Charlie Robbins notifications@github.com:
|
|
This PR doesn't completely solve the issue. In the case where the retry timeout has already been created, this will still end up throwing. I have a PR coming soon which will fix this issue and a bunch of others I found getting nssocket ready for my own use. EDIT: Take a look at #41 |
|
@AlmirKadric +1 We should guard both |
Reconnect logic is now disabled when disconnect is by request (call to .end() or .destroy()).
This is not tested though, I don't have time for that. I may have missed some place where reconnect logic should be enabled back ( .retry.closed set to false ).