Fixes in Tasks #657
Merged
Fixes in Tasks #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusty
force-pushed
the
gus/task-fixes
branch
4 times, most recently
from
74d5a2c to
e8d19f9
Compare
gusty
force-pushed
the
gus/task-fixes
branch
2 times, most recently
from
68e10ea to
b108c62
Compare
gusty
force-pushed
the
gus/task-fixes
branch
2 times, most recently
from
52ee269 to
6a985da
Compare
gusty
force-pushed
the
gus/task-fixes
branch
from
6a985da to
140a26c
Compare
gusty
force-pushed
the
gus/task-fixes
branch
5 times, most recently
from
738df5d to
3e8595b
Compare
gusty
force-pushed
the
gus/task-fixes
branch
from
3e8595b to
bf49501
Compare
gusty
force-pushed
the
gus/task-fixes
branch
from
aa44a44 to
e658508
Compare
gusty
force-pushed
the
gus/task-fixes
branch
from
a02a410 to
4bf5d2f
Compare
gusty
force-pushed
the
gus/task-fixes
branch
from
8a4e943 to
bff7135
Compare
wallymathieu
approved these changes
Jan 1, 2026
wallymathieu
pushed a commit
that referenced
this pull request
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaskBuilder tests were failing since long, randomly see #660
This PR:
Start using task CE in some implementations, previously it wasn't possible because of an F# compiler bug which was fixed in subsequent versions.
Harmonize code between Task and ValueTask
Fixes some bug related to exception wrapping/unwrapping in some operations
Enable Taskbuilder tests, bypassing some of them, specially the ones doing Thread.Sleep operations, see an explanation of why these tests fail frequently in the linked issue
It also adds more test coverage