Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
test/Scripts.Integration.Test/Scripts/IntegrationOptionsConfiguration.cs
Outdated
Show resolved
Hide resolved
src/Sentry.Unity.Editor/ConfigurationWindow/SentryEditorWindowInstrumentation.cs
Show resolved
Hide resolved
| #endif | ||
| return arg; | ||
| } | ||
| #endif |
There was a problem hiding this comment.
Duplicated GetTestArg across TestLauncher and SmokeTester
Low Severity
TestLauncher.GetTestArg() is a near-identical copy of the existing SmokeTester.GetTestArg(). Both contain the same platform-specific logic for Android intents, iOS DllImport, WebGL query strings, and desktop command-line args. SmokeTester could call the now-internal TestLauncher.GetTestArg() instead of maintaining its own private copy.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| adb shell input keyevent 82 | ||
| adb devices -l | ||
| pwsh ./scripts/smoke-test-android.ps1 -WarnIfFlaky | ||
| pwsh -Command '$env:SENTRY_TEST_APK = "samples/IntegrationTest/Build/test.apk"; Invoke-Pester -Script test/IntegrationTest/Integration.Tests.ps1 -CI' |
There was a problem hiding this comment.
Pester -Script and -CI parameter set conflict
High Severity
The Invoke-Pester command uses -Script (from the deprecated Legacy parameter set) together with -CI (from the Simple/Default parameter set). In Pester v5, these belong to different parameter sets and PowerShell does not allow combining parameters from different sets. This will cause a parameter binding error, preventing the integration tests from running. The -Script parameter needs to be replaced with -Path, which is in the same Simple parameter set as -CI.
1 participant
#skip-changelog