PatchCat integration + modifying testing behaviour based on herustic#113
PatchCat integration + modifying testing behaviour based on herustic#113carolhanna01 wants to merge 6 commits intogintool:llmfrom
Conversation
sandybrownlee
left a comment
There was a problem hiding this comment.
Generally looks good - just a couple of thoughts:
For using "iteration" as the evaluation number - good question. It's not an evaluation as such, but we do probably want to track it somehow still. Maybe we still use iteration, but instead of 0 for fitness we use NaN? So the patch shows as obviously not evaluated.
For Action A; keeping the solution needs us to do bestPatch = patch either as part of implementClusterAction or just after it as bestPatch is what will be used to make the neighbour next time. We don't want to do "best = newFitness" though as we don't have a fitness.
More minor things:
Do we want to add a parameter to allow easy reversion back to the original behaviour? Something like
@Argument(alias = "pc", description = "Enable patchCat")
protected Boolean patchCat = false;
Then just an if block around "enable patchcat integration"
It's worth changing the System.out.println() calls to Logger.info()
No description provided.