feat(config): Return error when Peering has stateful NAT on both sides #1248
+68
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not currently support stateful NAT on both sides of a peering. Make sure to return a config error if users attempt to do it anyway. Link: githedgehog/internal#260 Reported-by: Pau Capdevila <pau@githedgehog.com> Signed-off-by: Quentin Monnet <qmo@qmon.net>
mvachhar
approved these changes
Jan 28, 2026
Member
Author
|
Some bolero test may generate peerings with stateful NAT on both sides, I'll adjust it |
auto-merge was automatically disabled
January 28, 2026 16:52
Pull request was converted to draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not currently support stateful NAT on both sides of a peering. Make sure to return a config error if users attempt to do it anyway.
Link: https://github.com/githedgehog/internal/issues/260