-
Notifications
You must be signed in to change notification settings - Fork 8
add documentation for l2 externals #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
🚀 Deployed on https://preview-257--hedgehog-docs.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive documentation for L2 External peering to address issue #246. The documentation explains how to configure Layer 2 external connections as an alternative to the existing BGP-speaking (L3) external connections, using the Hedgehog Gateway for connectivity.
Changes:
- Updated introduction to mention L2/L3 connectivity and Hedgehog Gateway option
- Restructured documentation to distinguish between BGP-speaking and L2 externals
- Added detailed sections on L2 External objects, attachments, and VPC peering
- Included YAML configuration examples for L2 external setup
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
74866ed to
093dc64
Compare
pau-hedgehog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. I would suggest some clarifications/refinements
Also the hhfab external parameters changed. Should we update in the relevant sections?
Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>
Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>
093dc64 to
05c88c2
Compare
|
it would be good at some point to add an example of l2-external e.g. using the virtual external in vlab, but I figure that there are higher priority items in the backlog and we can do that later; if that's not correct let me know and I can re-prioritize |
|
converting to draft as we might be simplifying the APIs |
Fix #246