C++ / JS / python: Be consistent in TRAP sections #20957
+40,367
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igfoo
force-pushed
the
igfoo/consistent-metadata-and-overlay-support
branch
2 times, most recently
from
6479657 to
0419413
Compare
igfoo
force-pushed
the
igfoo/consistent-metadata-and-overlay-support
branch
from
0419413 to
997fe29
Compare
igfoo
force-pushed
the
igfoo/consistent-metadata-and-overlay-support
branch
from
997fe29 to
c429e00
Compare
Member
Author
|
ql-for-ql failures seems to be unrelated to this PR, e.g. https://github.com/github/codeql/actions/runs/20967345319/job/60261261271 fails the same way on |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the organization of TRAP section comments for database metadata and overlay support across C++, JavaScript, and Python dbscheme files. The changes introduce consistent section headers and documentation for the databaseMetadata and overlayChangedFiles tables.
Changes:
- Added "Database metadata" and "Overlay support" section headers across language dbschemes
- Updated documentation to clarify CLI behavior for both tables
- Added regeneration instructions to Python's dbscheme header comment
Reviewed changes
Copilot reviewed 21 out of 43 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| python/ql/lib/semmlecode.python.dbscheme | Added section headers and updated documentation for metadata/overlay tables |
| python/extractor/semmle/dbscheme_gen.py | Added dbscheme regeneration instruction to header template |
| python/extractor/semmle/dbscheme.template | Added section headers and updated documentation for metadata/overlay tables |
| javascript/ql/lib/semmlecode.javascript.dbscheme | Added section headers and updated documentation for metadata/overlay tables |
| cpp/ql/lib/semmlecode.cpp.dbscheme | Added section headers for metadata/overlay tables |
| python/ql/lib/upgrades/*/old.dbscheme | Historical dbscheme snapshots with new section organization |
| javascript/ql/lib/upgrades/*/old.dbscheme | Historical dbscheme snapshots with new section organization |
| python/downgrades/*/upgrade.properties | Upgrade metadata files for schema versioning |
| javascript/downgrades/*/upgrade.properties | Upgrade metadata files for schema versioning |
| cpp/downgrades/*/upgrade.properties | Upgrade metadata files for schema versioning |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
We now use the shared "Overlay support" and "Database metadata".
We now use the shared "Overlay support" and "Database metadata".
We now use the shared "Overlay support" and "Database metadata".
We now use the shared "Overlay support" and "Database metadata".
igfoo
force-pushed
the
igfoo/consistent-metadata-and-overlay-support
branch
from
617e4f3 to
ed38609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
and
sections consistent between the languages.